Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3pt] GVAL rio write_crs warning #1229

Closed
RobHanna-NOAA opened this issue Jul 19, 2024 · 1 comment · Fixed by #1253
Closed

[3pt] GVAL rio write_crs warning #1229

RobHanna-NOAA opened this issue Jul 19, 2024 · 1 comment · Fixed by #1253
Assignees
Labels
dependencies Pull requests that update a dependency file FIM4 Med Priority

Comments

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Jul 19, 2024

Soon PR 1217 will be merged which has a number of upgrades, which include OpenJDK and a bunch of python packages. One of the packages upgraded is GVAL, which now goes up to 0.2.7.

When FIM runs indirectly calls GVAL, a large number of new warnings are being issued. It is filling our screen output and masking possible true issues.

/usr/local/lib/python3.10/dist-packages/gval/comparison/agreement.py:134: FutureWarning: It is recommended to use 'rio.write_crs()' instead. 'rio.set_crs()' will likelybe removed in a future release.
agreement_map.rio.set_crs(crs, inplace=True)

Granted, It is assume the warning is coming from GVAL,. but this needs to be confirmed.

It is strongly encourage not to add code to suppress warnings, but it is encouraged to address them to avoid future surprises.

@RobHanna-NOAA
Copy link
Contributor Author

Greg fixed and released gval=="0.2.7.post1" but in testing, it does not appear to fix the problem. This is a low priority and can be re-assessed after the docker updates via 1217 are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file FIM4 Med Priority
Projects
None yet
2 participants