Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] Update "generate_nws_lid.py" and generate new NWS lid points, including Alaska points #1132

Closed
AliForghani-NOAA opened this issue Apr 26, 2024 · 6 comments · Fixed by #1159
Assignees
Labels
CatFIM NWS Flood Categorical HAND FIM enhancement New feature or request FIM4

Comments

@AliForghani-NOAA
Copy link
Collaborator

Update "generate_nws_lid.py" and generate new NWS lid points, including Alaska points.
Also, need to compare new lid points (simply in QGIS) with previous ones. There may be a few changes (additions/removals) in the points for the CONUS domain but we mainly want to see the AK forecast points added -- need the updated lid points for AK, before we can generate catfim.

@AliForghani-NOAA AliForghani-NOAA added enhancement New feature or request CatFIM NWS Flood Categorical HAND FIM FIM4 labels Apr 26, 2024
@AliForghani-NOAA AliForghani-NOAA self-assigned this Apr 26, 2024
@mluck
Copy link
Contributor

mluck commented Apr 26, 2024

This might be a duplicate of #1130.

@AliForghani-NOAA
Copy link
Collaborator Author

AliForghani-NOAA commented Apr 26, 2024

This issue is about updating tools/generate_nws_lid.py. Does issue #1130 involve only updating this file?

@mluck
Copy link
Contributor

mluck commented Apr 26, 2024

Ah, you're right.

@AliForghani-NOAA
Copy link
Collaborator Author

@CarsonPruitt-NOAA
This map displays 4741 NWS_LID points compiled using tools/generate_nws_lid.py:
image

Here I am retrieving stations from these two groups:

  • lid stations with rfc_forecast_point= True
  • lid stations in /data/inputs/ahp_sites/evaluated_ahps_sites.csv

The lid stations in AK (Alaska), HI, and PR, with above two criteria have also been selected, as shown in the map. In the previous version of the code, all of lid stations in PR and HI (regardless of meeting above two criteria), were also being retrieved. I have updated this version to exclude such stations.

Similar to 'usgs_gages.gpkg' dataset compiled last week, the selected lid stations, including those in Alaska, will be stored in a single gpkg file (nws_lid.gpkg) with EPSG=5070. The Alaska stations can be identified using their HUC8 numbers (beginning with '19').

Could you please confirm:
1- If the above two criteria adequately compile all necessary NWS_lid stations
2- If it is correct to include all stations, especially Alaska stations, in a single gpkg file with EPSG=5070?

@CarsonPruitt-NOAA
Copy link
Collaborator

Thanks for the detailed review, Ali! Yes on both accounts. Let's move forward with what you have.

@AliForghani-NOAA
Copy link
Collaborator Author

Sounds Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CatFIM NWS Flood Categorical HAND FIM enhancement New feature or request FIM4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants