-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/emc: follow-up changes for PR #330 #345
Labels
enhancement
New feature or request
Comments
@climbfuji - did this get addressed in #330 or is it a follow on issue to be addressed? |
No, this is indeed follow-up work that will hopefully lead to less code and small performance gains. Hopefully someone from EMC can pick this up. |
Thanks, we will leave this open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
During the review process of #330, the following items were noted as follow-up work:
driver/fvGFS/atmosphere.F90
, the logic around lines 2152 is redundant - see https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/330/files/85faba53a23060b301c898a438d3df2c44fb14a3#diff-53ee59c906ed74739c938e8c964c9c4fc6b71627e5cd6a5741e2cdacedfc16ab for detailsdriver/fvGFS/atmosphere.F90
, remove comment in line 1615do nb=1,blen ...
)Describe the solution you'd like
See above
Describe alternatives you've considered
Leave things as is - not a good idea, since we will be missing out on expected performance improvements
Additional context
n/a
The text was updated successfully, but these errors were encountered: