-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FindVcvars.cmake #31
Comments
Changes have been integrated in the scikit-build project. Worth noting that related changes have already been integrated in Slicer in these commits: Could you confirm that the remaining tasks would be to backport the commits to the |
Relevant commits have been pushed to the v4.11 branch: |
Additionally, local checkout of Slicier 4.11 on each factory ( @allemangD Let me know if anything else need to be done to address this issue. |
The version of
FindVcvars.cmake
used here is a bit out-of-date and does not support any VS 2019 build.In particular, I am on VS 1929, which would be added by this PR: scikit-build/cmake-FindVcvars#1
It would also be helpful to update
FindVcvars
in Slicer proper once the above PR is merged; both on the master and v4.11 branches.The text was updated successfully, but these errors were encountered: