Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindVcvars.cmake #31

Open
allemangD opened this issue Nov 11, 2021 · 3 comments
Open

Update FindVcvars.cmake #31

allemangD opened this issue Nov 11, 2021 · 3 comments

Comments

@allemangD
Copy link
Contributor

allemangD commented Nov 11, 2021

The version of FindVcvars.cmake used here is a bit out-of-date and does not support any VS 2019 build.

In particular, I am on VS 1929, which would be added by this PR: scikit-build/cmake-FindVcvars#1

It would also be helpful to update FindVcvars in Slicer proper once the above PR is merged; both on the master and v4.11 branches.

@allemangD allemangD changed the title Update FindFcvars.cmake Update FindVcvars.cmake Nov 11, 2021
@jcfr
Copy link
Contributor

jcfr commented Nov 12, 2021

Changes have been integrated in the scikit-build project.

Worth noting that related changes have already been integrated in Slicer in these commits:
https://github.com/Slicer/Slicer/pull/5817/commits

Could you confirm that the remaining tasks would be to backport the commits to the v4.11 branch ?

@jcfr
Copy link
Contributor

jcfr commented Nov 12, 2021

Relevant commits have been pushed to the v4.11 branch:

image

@jcfr
Copy link
Contributor

jcfr commented Nov 12, 2021

Additionally, local checkout of Slicier 4.11 on each factory (metroxplex, overload and factory-south-macos) has been updated to include these commits.

@allemangD Let me know if anything else need to be done to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants