Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some biomass outputs only updated for non-new cohorts #1261

Open
samsrabin opened this issue Oct 11, 2024 · 2 comments
Open

Some biomass outputs only updated for non-new cohorts #1261

samsrabin opened this issue Oct 11, 2024 · 2 comments
Labels
bug - software engineering history output Pertaining to FATES history output variables

Comments

@samsrabin
Copy link
Contributor

samsrabin commented Oct 11, 2024

As part of cleaning up PR #1252, I found myself confused about something I did. This prompted me to do a deep dive on the VEGC biomass outputs to understand which are saved for all cohorts vs. only for non-new cohorts.

Variable Search sci.1.77.0_api.36.0.0
FATES_VEGC ih_totvegc_si All
FATES_VEGC_ABOVEGROUND hio_agb_si All
FATES_VEGC_PF hio_biomass_si_pft All
FATES_VEGC_SE_PF hio_biomass_sec_si_pft All
FATES_VEGC_AP hio_biomass_si_age All
FATES_VEGC_APPF hio_biomass_si_agepft Non-new
FATES_VEGC_ABOVEGROUND_SZPF hio_agb_si_scpf Non-new
FATES_VEGC_ABOVEGROUND_SZ hio_agb_si_scls Non-new
FATES_VEGC_SZ hio_biomass_si_scls Non-new
FATES_VEGC_SZPF ih_totvegc_scpf All

Specifically, during development of #1252 I discovered that summing FATES_VEGC_APPF across the age-class axis didn't result in the FATES_VEGC_PF values. I solved that by updating the former for every cohort, not just non-new ones.

This implies that non-new cohorts can have positive biomass, so they should never be skipped when processing biomass history outputs.

@samsrabin samsrabin added bug - software engineering history output Pertaining to FATES history output variables labels Oct 11, 2024
samsrabin added a commit to samsrabin/fates that referenced this issue Oct 11, 2024
@samsrabin
Copy link
Contributor Author

The NPLANT outputs have the same issue—at least the ones with per-ageclass axis are only calculated for non-new cohorts, but there are nonzero values in the new cohorts.

@samsrabin
Copy link
Contributor Author

samsrabin commented Oct 14, 2024

Here is a list of all variables that exclude new cohorts as of sci.1.78.3_api.36.1.0.

Only one variable is saved for new cohorts only: FATES_RECRUITMENT_CFLUX_PF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - software engineering history output Pertaining to FATES history output variables
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant