Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit should be zero and gas should not exceed allowance or max gas for a transaction #549

Closed
petersalomonsen opened this issue Dec 2, 2023 · 4 comments · Fixed by #552
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@petersalomonsen
Copy link
Collaborator

petersalomonsen commented Dec 2, 2023

Is your feature request related to a problem? Please describe.
For NearSocial/VM#156 to work, and in order to solve #137 there cannot be any deposit or a gas amount that will trigger wallet redirection

Describe the solution you'd like
Deposit should be removed, and gas should not be more than MAX_GAS ( https://github.com/near/near-api-js/blob/858b8ee35ffc7d6409b3d72b01f59f4e117db613/packages/cookbook/utils/calculate-gas.js#L10 )

@Vayras
Copy link

Vayras commented Dec 3, 2023

Hi, @petersalomonsen I would like to contribute towards this issue, can you please assign me to this, Thank you

@petersalomonsen
Copy link
Collaborator Author

petersalomonsen commented Dec 4, 2023

Great if you pick it up @Vayras . It is also essential for me to get resolved in order to finish my work here: NearSocial/VM#156 (comment)

cc @frol

@Vayras
Copy link

Vayras commented Dec 5, 2023

Hi, @petersalomonsen can you help me by pointing out the files associated with this issue?

@elliotBraem
Copy link
Contributor

elliotBraem commented Dec 5, 2023

Hi @petersalomonsen and @Vayras;

I've created a PR from the develop branch with my attempt at this story for your review. I've merged it to develop branch so we can collaborate any further to complete NearSocial/VM#156 (comment) while ensuring we don't impact production.

I removed the deposit from all function calls to DevHub contract in our codebase, and set the gas for all of them to Big(10).pow(14) (MAX_GAS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants