Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of tinkers installed causes console spam of recipe unable to be parsed for tinkers compat recipes #236

Open
DelviousCrafts opened this issue Apr 6, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@DelviousCrafts
Copy link

Mod loader

Forge

Minecraft version

1.19

Beyond Earth version

6.4c

Modloader version

Forge: 43.2.8

The latest.log file

https://gist.github.com/DelviousCrafts/79168c707259a6d7b0bfc30120083bc1

Issue description

Conditions in the recipe for compat with Tinkers cause spam in the console of inability to parse the recipe when Tinkers is not installed. This is due to a condition that is only present in Tinkers, and if Tinkers is not installed the recipe parser does not recognize the condition. A way to fix this is to use a conditionally loaded data recipe, instead of simply a double condition, checking to see if Tinkers is installed first, then using the condition within the recipe if the condition succeeds. An example of this fix is attached.

ore_singular.zip

Steps to reproduce

  1. Install Beyond Earth without Tinkers
  2. Load game and find spam of recipe errors in console

Other information

No response

@DelviousCrafts DelviousCrafts added the bug Something isn't working label Apr 6, 2023
@dikivan2000
Copy link

@DelviousCrafts does this interfere with gameplay without tinkers by any chance? Can I just ignore these errors?

@DelviousCrafts
Copy link
Author

DelviousCrafts commented Sep 13, 2023

Yes, it can be ignored as it causes no gameplay issues. However, it can also be negated completely by using the format in the example here by calling the condition to check if the mod is loaded before bothering to load the recipe.

@dikivan2000
Copy link

Thanks for the info. There seems to be more issues like this (#256) that the dev calls "normal" in Discord so I ended up avoiding the mod altogether. Maybe next time when it's a bit more polished...

@st0x0ef
Copy link
Contributor

st0x0ef commented Sep 13, 2023

I never said that it's normal...

@dikivan2000
Copy link

I never said that it's normal...

I beg to differ. https://discord.com/channels/698598471896268931/1006528459801100478/1139460727594287144

@st0x0ef
Copy link
Contributor

st0x0ef commented Sep 13, 2023

OK yes

What I want to say is that I know this issue and it's normal that you're get this error. It's not my priority for now to fix that since I've a lot more of things to do now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants