Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login-links.js config for login page handler is wrong type #31

Open
bmcminn opened this issue Feb 25, 2016 · 0 comments
Open

login-links.js config for login page handler is wrong type #31

bmcminn opened this issue Feb 25, 2016 · 0 comments

Comments

@bmcminn
Copy link

bmcminn commented Feb 25, 2016

The [data-mz-action="loginpage-submit"] binding in product.js is initialized as new SignupPopover() instead of new LoginPopover(), which causes it to go down a wierd code path that doesn't trigger a proper redirect to the myaccount view.

https://github.com/Mozu/core-theme/blob/master/scripts/modules/login-links.js#L316-L317

The second part to this is changing the handleLoginComplete method to check for the redirectTemplate so that we can redirect the user as needed.

My changes to fix this can be seen in this commit on my personal theme: bmcminn/mozu-demo-theme@16419b4?w=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant