From da0397a69145b8b34de431f214ce5703345682be Mon Sep 17 00:00:00 2001 From: Aly Fluckey Date: Wed, 13 Dec 2023 17:02:32 -0500 Subject: [PATCH] fix(glean): change page_url & referrer_url to be url type --- telemetry/generated/web.ts | 6 +++--- telemetry/metrics.yaml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/telemetry/generated/web.ts b/telemetry/generated/web.ts index e74ffb308c..55d2d6af18 100644 --- a/telemetry/generated/web.ts +++ b/telemetry/generated/web.ts @@ -4,8 +4,8 @@ // AUTOGENERATED BY glean_parser v8.1.1. DO NOT EDIT. DO NOT COMMIT. +import UrlMetricType from "@mozilla/glean/private/metrics/url"; import EventMetricType from "@mozilla/glean/private/metrics/event"; -import StringMetricType from "@mozilla/glean/private/metrics/string"; /** * Event triggered when a user clicks a link on a web page. @@ -39,7 +39,7 @@ export const linkClick = new EventMetricType<{ * * Generated from `web.page_url`. */ -export const pageUrl = new StringMetricType({ +export const pageUrl = new UrlMetricType({ category: "web", name: "page_url", sendInPings: ["events"], @@ -77,7 +77,7 @@ export const pageView = new EventMetricType({ * * Generated from `web.referrer_url`. */ -export const referrerUrl = new StringMetricType({ +export const referrerUrl = new UrlMetricType({ category: "web", name: "referrer_url", sendInPings: ["events"], diff --git a/telemetry/metrics.yaml b/telemetry/metrics.yaml index 2f1031305b..37be6bb2e8 100644 --- a/telemetry/metrics.yaml +++ b/telemetry/metrics.yaml @@ -241,7 +241,7 @@ ui: web: page_url: - type: string + type: url description: > The full URL of the page that was visited, along with URL query parameters. @@ -264,7 +264,7 @@ web: - events referrer_url: - type: string + type: url description: > The full URL of the previous web page from which a link was followed in order to trigger the page view.