Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentForm deletion within DocumentFormSet #5

Open
m-vdb opened this issue Sep 24, 2012 · 0 comments
Open

DocumentForm deletion within DocumentFormSet #5

m-vdb opened this issue Sep 24, 2012 · 0 comments

Comments

@m-vdb
Copy link

m-vdb commented Sep 24, 2012

Not sure that the method used to check if a form has been deleted is right in this file. Django formset use the following test:

if form in formset.deleted_forms

In the case when data doesn't validate and is part of a deleted form, form.cleaned_data does not exist, and the way we test it can lead to problems (and in the worst case won't do everything we want...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant