Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "final_model()" to "finalize_model()" #87

Open
AntonioNoack opened this issue May 30, 2021 · 0 comments
Open

Rename "final_model()" to "finalize_model()" #87

AntonioNoack opened this issue May 30, 2021 · 0 comments

Comments

@AntonioNoack
Copy link

In the English language, "final" is an adjective, not a predicate. The name "final model" therefore sounds like a thing, not an action.
So I'd propose to rename the function (and keep a redirect for compatibility) to "finalize_model".

This change would help newcomers, especially from an English background.

Of course, all documentation would need to be updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant