Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should ensemble_model() have boolean expression for model selection? #56

Open
saramortara opened this issue Aug 21, 2019 · 1 comment
Open
Assignees

Comments

@saramortara
Copy link
Member

in cases that the user may want something like 0.7 <TSS < 1 or TSS > 0.7 & pval_pROC > 0.05?

@AndreaSanchezTapia AndreaSanchezTapia self-assigned this Aug 22, 2019
@AndreaSanchezTapia
Copy link
Member

currently the selection is peformed by subsetting an index vector

sel.index <- 1:n.part
sel.index <- which(stats.algo[, select_par] >= select_par_val)

this vector is then used to subset many portions of the following code
tipo:

pond.stats <- stats.algo[, weight_par][sel.index]

to subset with an expression an option would be to use subset(), that receives an expression

select_expression = "TSS > 0.7"
base::subset(stats.algo, subset = select_expression)

and solve for the rest of the subsets or re-create the sel.index index, but still, an expression in the parameters is a character string that should be evaluated (there are many options for doing this, I was looking here)

@AndreaSanchezTapia AndreaSanchezTapia changed the title final_model should have boolean expression for model selection? should ensemble_model() have boolean expression for model selection? Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants