Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General entity riding feature #561

Open
BenCheung0422 opened this issue Aug 22, 2023 · 2 comments
Open

General entity riding feature #561

BenCheung0422 opened this issue Aug 22, 2023 · 2 comments
Labels
Code Quality Issue related to code quality/coding standard. F-Addition Issue related to addition of feature or system. Improvement Something that we can improve.

Comments

@BenCheung0422
Copy link
Member

BenCheung0422 commented Aug 22, 2023

Is your feature request related to a problem? Please describe.
It seems that boat and horse may be added in the future, so this feature is important.
If we need to implement the logic and idea correctly and completely, this feature (https://minecraft.fandom.com/wiki/Riding) would still be needed, instead of just targeting implementing the feature in the simplest and easiest way. This behaviour and direction have been used for a long time with Load and the static class structures as examples. (Taken from a Discord message in the boat post.)

Describe the solution you'd like
We should implement the riding feature. If boat is implemented with Boat as in #134, it would not be a standardized logic, i.e. not implemented completely and correctly. There should be a map (a BiMap is recommended.) mapping the entity riding relationships. The map should be stored in a separated file in save. When the save system is rewritten, the data of the passenger can be instead recorded within an entity recursively instead of using a separated mapping. The position of the passenger is led by the mount and the boat is controlled by the player when being ridden. An entity can only be ridden and/or riding not more than one entity not being ridden by the entity itself.

@BenCheung0422 BenCheung0422 added the Improvement Something that we can improve. label Aug 22, 2023
@DevWolf31
Copy link

This is fine.

@BenCheung0422
Copy link
Member Author

Also, #287 mentioned ridable entity, so this could be an important feature, and #557 mentioned minecart, which might be possible and more realizable if the whole entity moving control system is rewritten.

@BenCheung0422 BenCheung0422 changed the title Entity riding feature General entity riding feature Aug 25, 2024
@BenCheung0422 BenCheung0422 added F-Addition Issue related to addition of feature or system. Code Quality Issue related to code quality/coding standard. labels Aug 27, 2024
@BenCheung0422 BenCheung0422 moved this to Todo in 2.3: Rewrite 1 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality Issue related to code quality/coding standard. F-Addition Issue related to addition of feature or system. Improvement Something that we can improve.
Projects
Status: Todo
Development

No branches or pull requests

2 participants