Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk Lighting Update Delayed #64

Open
dexman545 opened this issue Jun 15, 2016 · 7 comments
Open

Chunk Lighting Update Delayed #64

dexman545 opened this issue Jun 15, 2016 · 7 comments
Labels
bug temporalfix

Comments

@dexman545
Copy link

Using Stellar Sky 0.4.4.1 and StellarAPI 0.4.3.2b on MC 1.9.4 and Forge 1963

When placing/removing torches near a chunk border, the lighting does not always spread across the chunk border until the adjacent chunk is given a block update.

Images: https://imgur.com/a/1JtZF
The images were taken while other mods were installed, but I have confirmed that this happens with just stellar sky installed.
@Abastro Abastro added the bug label Jun 15, 2016
@Abastro
Copy link
Contributor

Abastro commented Jun 15, 2016

Does this happen only with Stellar API?

@dexman545
Copy link
Author

no, it does not appear to happen with just Stellar API

@Abastro
Copy link
Contributor

Abastro commented Jun 16, 2016

Reproduced this bug, only with Stellar API.
Would you migrate this issue to Stellar API?

@Abastro
Copy link
Contributor

Abastro commented Jun 16, 2016 •
edited
Loading

Was a forge bug.
2016-06-16_15 29 05
MinecraftForge/MinecraftForge#2991

@dexman545 dexman545 mentioned this issue Jun 16, 2016
Closed
@dexman545
Copy link
Author

This issue was moved to MinecraftModDevelopmentMods/StellarAPI#3

@Abastro Abastro reopened this Jun 21, 2016
@Abastro
Copy link
Contributor

Abastro commented Jun 21, 2016

It seems that Stellar Sky triggers vanilla bug.
Reopened this issue to keep this in mind.

Abastro added a commit that referenced this issue Jun 21, 2016
@Abastro
Temporally reduces rate of #64 significantly.
1bea05f
@Abastro Abastro modified the milestone: lighting bugix Jun 21, 2016
Abastro added a commit that referenced this issue Jun 21, 2016
@Abastro
Temporal but effective fix for #64
7c0ecd5 
This will be the version .1 release.
@Abastro
Copy link
Contributor

Abastro commented Jun 21, 2016

Note that temporal fix had applied.

@Abastro Abastro marked this as a duplicate of #74 Jul 18, 2017
@Abastro Abastro mentioned this issue Jul 18, 2017
Closed
@Abastro Abastro changed the title Lighting Update Bug Chunk Lighting Update Delayed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug temporalfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dexman545 @Abastro