Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders #9

Open
Phoenix616 opened this issue Sep 11, 2021 · 3 comments
Open

Placeholders #9

Phoenix616 opened this issue Sep 11, 2021 · 3 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement New feature or request Hacktoberfest service A new service which Tresor should add
Milestone

Comments

@Phoenix616
Copy link
Member

Phoenix616 commented Sep 11, 2021

Issuehunt badges

Add a provider abstractions for the different placeholder systems.


IssueHunt Summary

Backers (Total: $20.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips

@Phoenix616 Phoenix616 added the enhancement New feature or request label Sep 11, 2021
@Phoenix616 Phoenix616 added this to the Full Release milestone Sep 11, 2021
Copy link

issuehunt-oss bot commented Apr 19, 2024

@phoenix616 has funded $20.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Apr 19, 2024
@IllusionTheDev
Copy link
Contributor

The main issue I'm seeing here is the required underscore with PlaceholderAPI but not with MVDW, as well as the PAPI and MVDW formats being different (%name_value% vs {name}). For more specific placeholders ("%island_top_1%") it'd be great to build some kind of context tree. Not sure how fancy I'd like this to be

@Phoenix616
Copy link
Member Author

Phoenix616 commented Apr 28, 2024

I don't think the format difference would be a big issue. The basis is the same after all: A key which gets mapped to a value. How that key is replaced and represented internally in the plugins providing the service interface shouldn't really matter for the interface itself. Imo. an interface providing simple key -> value mapping as well as utility methods to replace in strings should be enough. (Although the more I think about text-related stuff I realise that with components being a thing this might get a lot more complicated as we would ideally want component support in the api but not all platforms or plugins use the same ones (Adventure vs. Bungee-Chat vs. other libraries/NMS access). I guess for now a simple string placeholder querying and replacement would be enough and components support could be part of #8, maybe once the ecosystem finally settles on one implementation...)

@Phoenix616 Phoenix616 added the service A new service which Tresor should add label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement New feature or request Hacktoberfest service A new service which Tresor should add
Projects
Status: Accepted service
Development

No branches or pull requests

2 participants