Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement searching password hashes using split database #186

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aseigler
Copy link
Contributor

Resolves #185

@aseigler
Copy link
Contributor Author

Old way:

PS R:\> (Measure-Command { $dsaccounts | Test-PasswordQuality -WeakPasswordHashesSortedFile R:\pwned.txt }).TotalMilliseconds
2141.1098

New way:

PS R:\> (Measure-Command { $dsaccounts | Test-PasswordQuality -WeakPasswordHashesSortedFilePath R:\hibp_files\ }).TotalMilliseconds
850.2169

@aseigler aseigler marked this pull request as ready for review September 23, 2024 15:39
@MichaelGrafnetter
Copy link
Owner

Hey @aseigler , thx for this nice PR. Could you please update the markdown documentation for the cmdlet as well, perhaps with an example? I am also not sure, if the command would work properly when both WeakPasswordHashesSortedFile and WeakPasswordHashesSortedFilePath are used.

@aseigler
Copy link
Contributor Author

Hey @aseigler , thx for this nice PR. Could you please update the markdown documentation for the cmdlet as well, perhaps with an example?

Sure, no problem.

I am also not sure, if the command would work properly when both WeakPasswordHashesSortedFile and WeakPasswordHashesSortedFilePath are used.

This would definitely be an either/or situation, it would make no sense to try to do both in a single command, but checking for that case is simple enough as well.

@aseigler
Copy link
Contributor Author

Ready for review again.

@aseigler
Copy link
Contributor Author

Bump. @MichaelGrafnetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-PasswordQuality directly with SPLIT database from HIBP
2 participants