Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fails when git is not configured (i.e. run as root) #410

Open
Atemu opened this issue Aug 4, 2024 · 0 comments
Open

Merge fails when git is not configured (i.e. run as root) #410

Atemu opened this issue Aug 4, 2024 · 0 comments

Comments

@Atemu
Copy link
Contributor

Atemu commented Aug 4, 2024

I just tried running nixpkgs-review as root because I wanted to use a nix store on a different drive and ran into this:

$ git merge --no-commit --no-ff 927fc72f6a5e35823543b194b6aa14a57fcfc8b2
Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'root@SOTERIA.(none)')
https://github.com/NixOS/nixpkgs/pull/331966 failed to build: Failed to merge 927fc72f6a5e35823543b194b6aa14a57fcfc8b2 into /root/.cache/nixpkgs-review/pr-331966/nixpkgs. git merge failed with exit code 128

nixpkgs-review should not depend on any git configuration and should just provide git with placeholders here as we don't actually care about the merge commit metadata here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant