Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports for PR runs should contain commit hashes #395

Open
mschwaig opened this issue Mar 26, 2024 · 1 comment
Open

Reports for PR runs should contain commit hashes #395

mschwaig opened this issue Mar 26, 2024 · 1 comment

Comments

@mschwaig
Copy link

I often read the results of a nixpkgs-revew run from ~/.cache/nixpkgs-review/pr-[pr-number].

One of the files in there, probably the report itself, should contain hashes of the commits in question, so that it's clear, without having to rely on my own memory, what exact version of the package set was actually built.

The relevant commit hashes are:

  • The tip of PR branch in question
  • The tip of the target branch, if --checkout merge is used
  • Maybe also the commit hash of the merge commit, if --checkout merge is used
@Mic92
Copy link
Owner

Mic92 commented Mar 27, 2024

Sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants