Retrieve and save error logs eagerly

[SomeoneSerge]

AFAIU, currently the build logs are retrieved during the Report generation, after all of the builds have been finished:

nixpkgs-review/nixpkgs_review/report.py

Line 133 in a45de7c

write_error_logs(self.attrs, directory)

In case of mass-rebuilds where a nixpkgs-review run might take a couple of days the build logs can get garbage-collected by that time, and nixpkgs-review would spit out empty files:

❯ bat logs/blender.log 
───────┬────────────────────────────────────────────────────────────────────────────────────────────
       │ File: logs/blender.log   <EMPTY>

[Mic92]

Maybe we should just disable this step if we go over some threshold of packages?

[Mic92]

We currently don't have a notification mechanism if an attribute is built.

[SomeoneSerge]

I thought nom displays the built and failed packages. Maybe json-internal includes some build result message?

Maybe we should just disable this step if we go over some threshold of packages?

The thing is, logs are the main reason I run nixpkgs-review 😅

[Mic92]

Might be a solution. I haven't yet digged into how json-internal works. I know however that it's not reliable in nom when having remote builders. Some builds are reported pending also they already have finished.