Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with nix-fast-build #365

Open
lovesegfault opened this issue Oct 9, 2023 · 2 comments
Open

Integration with nix-fast-build #365

lovesegfault opened this issue Oct 9, 2023 · 2 comments

Comments

@lovesegfault
Copy link

Since reviews often involve building a huge number of packages, it'd be nice if there was an easy way to ask nixpkgs-review to use https://github.com/Mic92/nix-fast-build under the hood.

@lovesegfault
Copy link
Author

One particularly useful outcome of this would be that it could support --retries.

@Mic92
Copy link
Owner

Mic92 commented Oct 20, 2023

Just now we don't support non-flake usage in nix-fast-build, so it would be a bit slower to start nix-fast-build on large repos such as nixpkgs. Also I just recently benchmarked nix-eval-jobs on nixpkgs and it seems to be significantly slower than just using nix-env -> Have to check where this slow down is coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants