Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onto option for --checkout #287

Open
figsoda opened this issue Dec 21, 2022 · 3 comments
Open

onto option for --checkout #287

figsoda opened this issue Dec 21, 2022 · 3 comments

Comments

@figsoda
Copy link
Collaborator

figsoda commented Dec 21, 2022 •
edited
Loading

It would be nice to be able to use git rebase --onto for the checkout options, this will make it easier to review prs targetting staging
@Mic92
Copy link
Owner

Mic92 commented Dec 24, 2022

From nixpkgs-review point of view how is a merge different from a rebase? I do not understand the issue here yet.

@figsoda
Copy link
Collaborator Author

figsoda commented Dec 24, 2022

With rebase --onto we can apply a staging pr to master so we don't have to rebuild the world to review a staging pr. I'm not aware of an alternative in nixpkgs-review currently

@Mic92
Copy link
Owner

Mic92 commented Dec 29, 2022

Ah. I see this makes now sense to me.

@pbsds pbsds mentioned this issue Aug 7, 2023
Merged
12 tasks
@kachick kachick mentioned this issue Sep 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mic92 @figsoda