Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy workflow #1086

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix deploy workflow #1086

merged 1 commit into from
Oct 18, 2024

Conversation

NicholasEllul
Copy link
Contributor

@NicholasEllul NicholasEllul commented Oct 18, 2024

Explanation

This pull request updates the deploy workflow to explicitly note the environment its part of (github-pages) and use the personal_token field as per the peaceiris/actions-gh-pages docs.

This mimics a similar setup as the Website repository here: https://github.com/MetaMask/website/blob/master/.github/workflows/integrate.yml

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit dc4874c into main Oct 18, 2024
7 of 8 checks passed
@christopherferreira9 christopherferreira9 deleted the ellul/deploy-workflow-fix branch October 18, 2024 16:50
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (c163fa5) to head (f886cbe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files         180      180           
  Lines        4260     4260           
  Branches     1050     1050           
=======================================
  Hits         3287     3287           
  Misses        973      973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants