Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Got "missing r" error when using EAS + Metamask + etherjs #97 #25032

Closed
xiaohou77 opened this issue Jun 4, 2024 · 3 comments
Closed
Assignees
Labels
external-contributor regression-prod-11.15.6 Regression bug that was found in production in release 11.15.6 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug

Comments

@xiaohou77
Copy link

xiaohou77 commented Jun 4, 2024

Describe the bug

Issue detail
In our dApp https://app.fairsharing.xyz/, when we make an onchain attestaion call, metamask returned the error as below snapshot below.

We use EAS + Metamask + etherjs. When we change wallet app to like OKX/Rabby wallet, it works well.

I found a relative issue ethers-io/ethers.js#3926, seems we have to wait for metamask to fix it?

Please help look into this issue, it is blocking many users using our dApp now.

Many people met the same issue too:
ethereum-attestation-service/eas-sdk#97

Expected behavior

No error reported by MetaMask extention since onchain call is successful.

Screenshots/Recordings

image

Steps to reproduce

  1. Go to: https://app.fairsharing.xyz/
  2. Create a project, then add 1 or 2 members by wallet addresses
  3. Adding members will fail

Error messages or log output

No response

Version

11.15.6

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

Before it works well, abour 1 month ago the issue started occuring.

Severity

P0
Many developers have reported this issue as well, see ethereum-attestation-service/eas-sdk#97

No response

@itev4n7
Copy link

itev4n7 commented Jun 4, 2024

possible solution described here ethereum-attestation-service/eas-sdk#97 (comment)

@gauthierpetetin gauthierpetetin added Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team labels Jun 4, 2024
@peterjurco
Copy link

I experienced "Missing r" error as well but it was fixed in MetaMask 11.16.0

@dbrans
Copy link
Contributor

dbrans commented Jun 6, 2024

I've marked this issue as fixed. If you run into this bug again on v11.16.0 or later, please let us know!

@dbrans dbrans closed this as completed Jun 6, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 6, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-11.15.6 Regression bug that was found in production in release 11.15.6 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug
Projects
Archived in project
Development

No branches or pull requests

7 participants