-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Starknet Snap docs #1509
WIP: Starknet Snap docs #1509
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Some notes on connect vs install:
|
wallet/how-to/use-non-evm-networks/starknet/connect-to-starknet.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/connect-to-starknet.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/connect-to-starknet.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/connect-to-starknet.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/connect-to-starknet.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/manage-starknet-networks.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/send-starknet-transactions.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/send-starknet-transactions.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/send-starknet-transactions.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/send-starknet-transactions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need some changes on api commented with "needs check" because the api changed. I will do a separate review for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions on the intro pages.
wallet/how-to/use-non-evm-networks/starknet/sign-starknet-data.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/send-starknet-transactions.md
Outdated
Show resolved
Hide resolved
wallet/how-to/use-non-evm-networks/starknet/sign-starknet-data.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const sendStarknetTransaction = async (contractAddress, contractFuncName, contractCallData, address, chainId, maxFee = null) => { | ||
const provider = await getEip6963Provider() | ||
// Or window.ethereum.isMetaMask if you don't support EIP-6963. | ||
const sendStarknetTransaction = async (address, chainId, contractAddress, entrypoint, calldata, maxFee = null) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated these params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if my edits are fine.
Description
Draft of Starknet Snap docs.
Issue(s) fixed
Fixes #1511
Fixes #1512
Fixes #1513
Fixes #1514
Fixes #1515
Fixes #1516
Fixes #1526
Preview
Preview: https://metamask-docs-git-wip-starknet-snap-metamask-web.vercel.app/wallet/how-to/use-non-evm-networks/starknet/sign-starknet-data/
(If out of date, see the Vercel link at the bottom of the PR activity for the latest preview.)
Checklist
Complete this checklist before merging your PR: