Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percent-encoded filenames #7

Open
MelleNooijen opened this issue Aug 16, 2020 · 1 comment
Open

Percent-encoded filenames #7

MelleNooijen opened this issue Aug 16, 2020 · 1 comment
Assignees
@elsandosgrande @MelleNooijen
Labels
enhancement New feature or request good first issue

Comments

@MelleNooijen
Copy link
Owner

Note: This feature is a long-term addition, meaning it is not meant to be implemented soon.
Add percent encoding for filenames, as this is currently only handled by the URL display code, and the files are never actually renamed. i.e. if someone uploads a filename with Japanese characters, the URL will be percent-encoded, while the filename itself will remain original. This can cause issues with some browsers, and requires more characters to be considered "illegal characters".
@MelleNooijen MelleNooijen added the enhancement New feature or request label Aug 16, 2020
@MelleNooijen
Copy link
Owner Author

Implemented percent-encoding using the JavaScript encodeURIComponent function. This feature is currently in testing as per 0.8b1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elsandosgrande elsandosgrande

@MelleNooijen MelleNooijen

Labels
enhancement New feature or request good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elsandosgrande @MelleNooijen