Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent additional attributes from being added to system/moves #58

Open
rsdefever opened this issue May 16, 2020 · 0 comments
Open

Prevent additional attributes from being added to system/moves #58

rsdefever opened this issue May 16, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rsdefever
Copy link
Collaborator

rsdefever commented May 16, 2020

Is your feature request related to a problem? Please describe.
It is easy to make a typo, and instead of editing an attribute of the moves object, you actually add an extra attribute (and do not make the intended edit). Example:

moves = Moves()
moves.cbmc_n_dihed = 15
# This is what I might try to do...but with a typo,
moves.cmbc_n_dihed = 15
# No error or warning is thrown, so I think I've modified cbmc_n_dihed,
# but actually it still has the default value

Describe the solution you'd like
system and moves have well defined attributes. The users can in some cases edit those attributes, but I see no need to add additional attributes. It would be good to throw an error if the user tries to create a new attribute.

Describe alternatives you've considered
Open to ideas, none come to mind immediately.

Other information
In some ways this is related to #49; now that we are closing in on the desired UX for MoSDeF Cassandra, it may be time to think about creating a somewhat more robust backend.

@rsdefever rsdefever self-assigned this May 16, 2020
@rsdefever rsdefever added the enhancement New feature or request label May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant