Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/despositall range is too large #7

Open
kotarobo opened this issue Apr 27, 2019 · 4 comments
Open

/despositall range is too large #7

kotarobo opened this issue Apr 27, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@kotarobo
Copy link

Using / depositall with operator authority will open the chest inventory around at a very fast rate.
At that time, I saw the movement to open up to the chest that was far away (this time was 48 blocks away).
The chest did not open when using default user rights. (I did not know if I could open a chest far away because I could not see the opening behavior.)

In any case, the cobblestones on hand were never used for the chest.

environment:
Paper-614 (MC: 1.13.2)
Plugins: https://pastebin.com/y0denhfZ

@kotarobo
Copy link
Author

Postscript
Depositall now works when testing by default, removing privileges from the operator.
It seems to just deposit even on the chest far away.

@RoboMWM
Copy link
Member

RoboMWM commented Apr 27, 2019

Ok, thanks for testing with non-op permissions. I believe /depositall works better when your chests are already partially filled with items so it knows which items go where.

Not sure what the normal use case is for most players, idk if they're expecting a maximum 48 block radius.

@RoboMWM RoboMWM changed the title Chest fast open /despositall range is too large May 1, 2019
@RoboMWM RoboMWM added the enhancement New feature or request label May 1, 2019
@RoboMWM RoboMWM removed the enhancement New feature or request label Aug 4, 2019
@RoboMWM
Copy link
Member

RoboMWM commented Oct 19, 2019

Ok, the code is set up to get and check all adjacent chunks from the player. So the max block length (from one side to another, not diagonal) would be 16 * 3, or 48 blocks, not including y value (which is 10 blocks below and above the player). This is because the check is done asynchronously in another thread.

This check makes sense for medium/large-sized homes, and making this smaller would cause chests that are across a chunk border to not be found.

@RoboMWM
Copy link
Member

RoboMWM commented Oct 19, 2019

I could add another check to limit the block size in general, but I think that's overkill and the issue isn't really a big deal afaik, just maybe annoying if you're too close to another player's claim.

@RoboMWM RoboMWM added the help wanted Extra attention is needed label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants