Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary(?) SONAME change #9

Open
thesamesam opened this issue Dec 14, 2021 · 2 comments
Open

Unnecessary(?) SONAME change #9

thesamesam opened this issue Dec 14, 2021 · 2 comments

Comments

@thesamesam
Copy link
Contributor

thesamesam commented Dec 14, 2021

Commit cd888d8 changed SONAME but at a quick check, it doesn't seem like this was necessary. This breaks compatibility with applications already linked against older libnids and forces them to be rebuilt.

Did the ABI of libnids actually change since the last release or was the SONAME just accidentally changed (here)?

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Dec 14, 2021
Seems to be accidental. Avoid breaking consumers.

Bug: MITRECND/libnids#9
Signed-off-by: Sam James <[email protected]>
@malwarefrank
Copy link
Contributor

I would actually prefer the SONAME to be minor-version agnostic rather than how it is now. Then the agnostic filename can be a symlink to the latest version-specific file. This is how other libraries are handled on some distributions. I see that the Ubuntu libnids package also has a version-specific name, but different than the one you reference.

I created a branch that looks for the SONAME environment variable at build time and uses that value for the SONAME, which would allow you to easily name it whatever you want, Ubuntu to name it their own way, but also have a sensible default (major-version specific but minor-version agnostic). Take a look at the branch and let me know what you think before I merge it into master and tag it as a new patch-level version.

@malwarefrank
Copy link
Contributor

@thesamesam thoughts on using an ENV var to set soname at build time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants