Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdditionalStylingPart on widgets outside of Flows (OSOE-595) #123

Open
sarahelsaig opened this issue Mar 15, 2023 · 1 comment
Open

AdditionalStylingPart on widgets outside of Flows (OSOE-595) #123

sarahelsaig opened this issue Mar 15, 2023 · 1 comment

Comments

@sarahelsaig
Copy link
Member

sarahelsaig commented Mar 15, 2023

I've noticed that AdditionalStylingPart gets welded to widget content items even when you add them to a zone durectly. Yet there is no visible editor for it and I don't think it actually does anything either. So you only see it when you export a content recipe, but when that happens I think this is a bit confusing.

We could do two different things, I'm not sure which would be more correct:

  • Somehow detect if the content item is inside a flow and welding AdditionalStylingPart if it's not. (Currently AdditionalStylingPartHandler only checks if the content it's definition has the "Widget" stereotype.)
  • Make the AdditionalStylingPart effective on regular zone-bound widgets too and display a simple editor. For example apply the CustomClasses to the widget-container.

Jira issue

@github-actions github-actions bot changed the title AdditionalStylingPart on widgets outside of Flows AdditionalStylingPart on widgets outside of Flows (OSOE-595) Mar 15, 2023
@0liver
Copy link
Contributor

0liver commented Mar 16, 2023

The second option sound desirable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants