-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run baseline package validation during NuGet publishing for major version changes (OSOE-857) #350
Labels
enhancement
New feature or request
Comments
github-actions
bot
changed the title
Don't run baselines package validation during NuGet publishing for major version changes
Don't run baselines package validation during NuGet publishing for major version changes (OSOE-857)
May 15, 2024
Piedone
changed the title
Don't run baselines package validation during NuGet publishing for major version changes (OSOE-857)
Don't run baseline package validation during NuGet publishing for major version changes (OSOE-857)
May 18, 2024
@sarahelsaig wasn't this an issue for you for https://github.com/Lombiq/Helpful-Libraries/releases/tag/v10.0.0? |
No, when I pushed a major tag it always worked. |
That's what I remembered doing before, but still, I had to do Lombiq/UI-Testing-Toolbox@803e87f to publish a new major version. It failed under https://github.com/Lombiq/UI-Testing-Toolbox/actions/runs/9100082776/job/25014098526 without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To allow breaking changes in major versions, something that the baseline package validator we use during NuGet publishing doesn't do (see dotnet/sdk#40907), let's not run it in such cases.
So, if
New-NuGetPackage
notices a major version change (e.g. from 1.2.3 to 2.0.0) then disable baseline package validation (but only that, package validation should otherwise run).If dotnet/sdk#40907 is implemented before, then this won't be needed.
Jira issue
The text was updated successfully, but these errors were encountered: