Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when no servers found #141

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Error when no servers found #141

merged 1 commit into from
Oct 14, 2020

Conversation

cjea
Copy link
Contributor

@cjea cjea commented Oct 14, 2020 •
edited
Loading

Fixes the swagger error of generating an empty list of server blocks when the --env option doesn't match any servers.
Issue: #120

$ ./reslang ~/code/reslang/models/servers --stdout --env JUNK
Reslang error:  no server found with environment "JUNK" (are you passing the correct value to --env?)
error Command failed with exit code 255.

This PR only addresses the swagger. I think asyncapi has the same problem, though the server blocks are handled a little differently

@ops-github-DU4JOAWE
Copy link

This change is Reviewable

@cjea cjea added the change/standard Trivial / minor changes that are low-impact, low risk label Oct 14, 2020
@cjea cjea requested a review from a team October 14, 2020 00:12
@cjea cjea mentioned this pull request Oct 14, 2020
Open
njaczko
njaczko approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@njaczko njaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above and beyond, CJ. thanks!

@cjea cjea merged commit c373f37 into master Oct 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the ISS-120/error-on-unmatched-env branch October 14, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njaczko njaczko njaczko approved these changes

Assignees
No one assigned
Labels
change/standard Trivial / minor changes that are low-impact, low risk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjea @ops-github-DU4JOAWE @njaczko