Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INI_ERR_INVALID_FILENAME is misleading #10

Open
Reissner opened this issue May 15, 2020 · 0 comments
Open

INI_ERR_INVALID_FILENAME is misleading #10

Reissner opened this issue May 15, 2020 · 0 comments

Comments

@Reissner
Copy link

Reissner commented May 15, 2020

In fact, the INI_ERR_INVALID_FILENAME is always when the stream cannot be opened.
That the filename is invalid is only one of the possible reasons.
This constant may be called INI_ERR_CANNOT_OPEN_STREAM_ON_FILE or something.

By the way, in my opinion, an enum would be much better.
Could be called sth like RWsucc or what.

Then of course, INI_ERR is superfluous
and we shall add sth like SUCCESS = 0.

Allows handling with switch and makes things somehow clearer.
If you want, i can send you a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant