-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests and functions dealing with config reading/writing #30
Comments
would refrain from having configs as .py files, as they're more prone to user error/less user friendly. Besides that, pytest has built-in functions for temporal directories that could be used for testing. |
All functional so far - tests check for default and user created homepage and metadata configs. Not sure how to proceed in the field of the metadata config. Would an interactive fill-out click function (as with the homepage config) be sensible? |
|
It's a nice convenience function, but depends on how much time you have to spare |
A function to create and open a well commented template file might be quicker to develop, less error prone and easier to maintain in the future |
Currently default-based tests are thrown off if a user-generated config exists. Config writing has not been turned into a test yet. Thus this issue encapsulates the following areas:
--> more importantly: making tests unintrusive to running collections; perhaps through a placeholder URL that does not actually lead anywhere and gets deleted again after testing
--> add a config retriever option that immediately chooses the default config, even if user config exists (could be good for testing)
--> implement format guidelines that throw errors if a user does not following them (i.e.
www. .de
instead ofhttps://www. .de/
)--> make a TEST!
In this vein, also test out if PK's idea to have the default configs as .py with dicts in them works and stops problems from popping up.
The text was updated successfully, but these errors were encountered: