Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the node schema pointer getter const #1320

Open
JustinPrivitera opened this issue Aug 22, 2024 · 0 comments
Open

Make the node schema pointer getter const #1320

JustinPrivitera opened this issue Aug 22, 2024 · 0 comments

Comments

@JustinPrivitera
Copy link
Member

Schema *schema_ptr()

This should be const like the reference version of this function. The problem with doing this is that several areas of Conduit are built on this being non const. So far I have discovered tests (t_conduit_node_move_and_swap) and the python interface that depends on this being non const.

return (PyConduit_Schema_Python_Wrap(self->node->schema_ptr(),0));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant