Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer const options for strided_structued #1299

Open
cyrush opened this issue Jul 18, 2024 · 0 comments
Open

prefer const options for strided_structued #1299

cyrush opened this issue Jul 18, 2024 · 0 comments
Labels
task

Comments

@cyrush
Copy link
Member

cyrush commented Jul 18, 2024

conduit/src/libs/blueprint/conduit_blueprint_mesh_examples.cpp

Line 3309 in 3a9b82c

fill_if_array_exists(desc, "vertex_data/shape", (npts_z > 0), pts_extent);

Uses desc which is an in/out style node.

We should refactor to use const options and if we need output, pass another node to hold the output metadata.
@cyrush cyrush added the task label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyrush