Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test include_includes #86

Open
sanjayankur31 opened this issue Aug 20, 2024 · 0 comments · May be fixed by #88
Open

Test include_includes #86

sanjayankur31 opened this issue Aug 20, 2024 · 0 comments · May be fixed by #88
Assignees
@sanjayankur31
Labels
T: bug T: enhancement

Comments

@sanjayankur31
Copy link
Contributor

When loading a new model, one can set include_includes=True or False. What should happen is:

  • when true, any Include... lines are replaced by the content of the included file
  • when false, the Include lines are kept as is

This may not be currently happening, so we need to add unit tests to confirm this behaviour and fix any bugs if present
@sanjayankur31 sanjayankur31 self-assigned this Aug 20, 2024
sanjayankur31 added a commit to sanjayankur31/NeuroML-widgets that referenced this issue Aug 20, 2024
@sanjayankur31
wip: simulation_manager
eb526bd 
Needs debugging of pylems: LEMS/pylems#86

TODO:

- allow choosing simulation engine
- save simulation date
- allow saving data over multiple simulations
sanjayankur31 added a commit that referenced this issue Sep 2, 2024
@sanjayankur31
fix: correctly handle include_includes in exports
17d2816 
- if `include_includes` is set, we replace the `Include` statements with
  their contents
- if not, the `Include` statements are kept as part of the model and
  when the model is exported, they're also exported.

Fixes #86
@sanjayankur31 sanjayankur31 linked a pull request Sep 2, 2024 that will close this issue
Correctly handle include includes #88
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanjayankur31 sanjayankur31

Labels
T: bug T: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly handle include includes LEMS/pylems
1 participant
@sanjayankur31