diff --git a/lems/parser/LEMS.py b/lems/parser/LEMS.py index 2cdb725..614b560 100644 --- a/lems/parser/LEMS.py +++ b/lems/parser/LEMS.py @@ -9,14 +9,12 @@ from lems.base.base import LEMSBase from lems.base.errors import ParseError - -from lems.model.fundamental import * +from lems.base.util import make_id from lems.model.component import * from lems.model.dynamics import * -from lems.model.structure import * +from lems.model.fundamental import * from lems.model.simulation import * - -from lems.base.util import make_id +from lems.model.structure import * def get_nons_tag_from_node(node): @@ -209,9 +207,9 @@ def init_parser(self): self.tag_parse_table["eventwriter"] = self.parse_event_writer self.tag_parse_table["derivedparameter"] = self.parse_derived_parameter self.tag_parse_table["derivedvariable"] = self.parse_derived_variable - self.tag_parse_table[ - "conditionalderivedvariable" - ] = self.parse_conditional_derived_variable + self.tag_parse_table["conditionalderivedvariable"] = ( + self.parse_conditional_derived_variable + ) self.tag_parse_table["case"] = self.parse_case self.tag_parse_table["dimension"] = self.parse_dimension self.tag_parse_table["dynamics"] = self.parse_dynamics @@ -1072,19 +1070,25 @@ def parse_include(self, node): :raises ParseError: Raised when the file to be included is not specified. """ + filename = None + + # TODO: remove this hard coding for reading NeuroML includes... + if "file" not in node.lattrib: + if "href" in node.lattrib: + filename = node.lattrib["href"] + else: + filename = node.lattrib["file"] + + if filename is None: + self.raise_error(" must specify the file to be included.") + if not self.include_includes: if self.model.debug: - print("Ignoring included LEMS file: %s" % node.lattrib["file"]) + self.model.add_include(Include(filename)) + print("Not including contents of %s" % filename) else: - # TODO: remove this hard coding for reading NeuroML includes... - if "file" not in node.lattrib: - if "href" in node.lattrib: - self.model.include_file(node.lattrib["href"], self.include_dirs) - return - else: - self.raise_error(" must specify the file to be included.") - - self.model.include_file(node.lattrib["file"], self.include_dirs) + self.model.include_file(filename, self.include_dirs) + print("Included contents of %s" % filename) def parse_kinetic_scheme(self, node): """ diff --git a/lems/test/LEMS_NML2_Ex2_Izh.xml b/lems/test/LEMS_NML2_Ex2_Izh.xml new file mode 100644 index 0000000..b1cefaf --- /dev/null +++ b/lems/test/LEMS_NML2_Ex2_Izh.xml @@ -0,0 +1,78 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/lems/test/test_load_write.py b/lems/test/test_load_write.py index bdea25e..3952ac6 100644 --- a/lems/test/test_load_write.py +++ b/lems/test/test_load_write.py @@ -3,7 +3,9 @@ """ +import os import unittest + from lems.model.model import Model @@ -30,3 +32,47 @@ def test_load_get_dom(self): file_name = "lems/test/hhcell_resaved2.xml" model.import_from_file(file_name) dom0 = model.export_to_dom() + + def test_include_includes_is_true(self): + """Test that include_includes works as expected""" + cwd = os.getcwd() + os.chdir("lems/test/") + model = Model( + include_includes=True, + fail_on_missing_includes=True, + ) + model.debug = True + model.add_include_directory("NeuroML2CoreTypes/") + + model.import_from_file("LEMS_NML2_Ex2_Izh.xml") + + model_string = model.export_to_dom().toprettyxml(" ", "\n") + print(model_string) + self.assertNotIn("