Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ComponentReference #54

Open
borismarin opened this issue Dec 18, 2014 · 2 comments
Open

Remove ComponentReference #54

borismarin opened this issue Dec 18, 2014 · 2 comments

Comments

@borismarin
Copy link
Contributor

After discussions at UCL with @robertcannon, we have decided that ComponentReferences are just adding entropy to LEMS, since all the cases where they are used can be straightforwardly implemented using Child(ren)s. Relates to #32.

@borismarin
Copy link
Contributor Author

With this decision in mind, it seems that all attributes in a <Component> definition should correspond to parameter values, isn't that right @robertcannon ? That will greatly simplify our lives, as we can bind the "any" attributes to something else than String.

@robertcannon
Copy link
Member

Yes, I think you're right, for the free ones. You've still got "type" and "extends" and possibly others with fixed names in future, but for normal components, the others would just set parameter values.
Though they won't necessarily all be physical quantities - the network stuff has xpath-like node selectors attribute values too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants