-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adventure weighs hue too heavily when comparing colors #1077
Comments
tbh not a priority for us to look into, since downsampling is rarely used outside of super legacy situations, but PRs are welcome (with visual comparisons) |
I'm writing code for the latest version of Paper, I'd like to make use of modern colors while still allowing legacy clients to be able to play my server without seeing god awful color translation. What do you need to see in the pull request? Is this not as simple as just removing the multiplication by three? |
legacy clients are at the bottom of our priority list these days, it's 2024 |
adventure/api/src/main/java/net/kyori/adventure/text/format/TextColorImpl.java
Line 71 in 5919a35
The distance method when comparing two colors causes a color like #f6fff5 (white with very slight green tint) to be downsampled to green instead of white.
The text was updated successfully, but these errors were encountered: