Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable server instances factories (singleton, etc) #102

Open
ShayOinif opened this issue Jun 15, 2024 · 2 comments
Open

Configurable server instances factories (singleton, etc) #102

ShayOinif opened this issue Jun 15, 2024 · 2 comments

Comments

@ShayOinif
Copy link

Hello, i know this lib is very new and things are still moving.
But I like the concept very much, and I would love to use it in some of my projects.
I have 2 main issues:

  1. My server side is going to be on Linux and right now there isn't ktor server transport for this target.
  2. As I see the impl and underlying protocol, I have to create a KRPC server for each client.
    I would love to simply supply the same instance for all clients.
    I understand that the main reason is ID'S not being unique between different client calls.
    Maybe uuid v7 which is time based can be used?
    Anyhow, I know that some work around could be to make my impl for the service an inner class of main service or singleton and make them very thin and simply redirect the calls to main/singleton service.
    But still, I don't like all this instantiation.

Thanks in advance and I am really looking forward to use this lib in my code!

@Mr3zee
Copy link
Collaborator

Mr3zee commented Jul 15, 2024

Hi, @ShayOinif ! These are two different requests as I see
First one can be represented by #95 and #83 , while the second one more complicated.
It will be a part of a bigger protocol rework we plan for later, as we have a lot of things to consider at once, so we want to take out time with it

@Mr3zee
Copy link
Collaborator

Mr3zee commented Jul 15, 2024

I will rename the issue to address only the second point

@Mr3zee Mr3zee changed the title Ktor transport (server/client) for more tragets Configurable server instances factories (singleton, etc) Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants