-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pybind11 gil_scoped_acquire #354
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi SMTK maintainers, could you please participate in the discussion under pybind/pybind11#4216 & pybind/pybind11#4218?
In a nutshell, pybind11 comes with two implementations of
gil_scoped_acquire
, let's call them "simple" and "non-simple". The current default non-simple implementation is known to be buggy from bug reports and inspection (PR #4216). My vote (as one maintainer) is to remove the non-simple version entirely, to stop sending users into traps, but your project depends on it. We need to find a way to avoid sending pybind11 users into traps, but ideally not break your project with the next release. One obvious option would be to make the simple version the default, but keep the non-simple version in pybind11 behind a define that your project could use, but then we still have to maintain the non-simple code and explain why it is there. In the long run my preference would be to transfer the non-simple code elsewhere, maybe with cooperating changes in pybind11, but we need to figure out what exactly is needed.The text was updated successfully, but these errors were encountered: