Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support R16G16_S10_5_NV format #859

Closed
MarkCallow opened this issue Feb 13, 2024 · 0 comments · Fixed by #864
Closed

Support R16G16_S10_5_NV format #859

MarkCallow opened this issue Feb 13, 2024 · 0 comments · Fixed by #864

Comments

@MarkCallow
Copy link
Collaborator

MarkCallow commented Feb 13, 2024 •
edited
Loading

Over in KhronosGroup/KTX-Specification#206 we've decided to support this format.

It is in vkFormatString and isValidFormat so ktx info and ktx validate should be fine as these are the functions they use for printing the name and checking validity. vk2dfd however produces nothing for this format. makevk2dfd.pl needs to be fixed and some tests added. Once that is fixed the code in unittests.cc to avoid running the bytesPlane0 test for this format must be removed.

There is no intention to support this in ktx create except via raw files.
@MarkCallow MarkCallow mentioned this issue Feb 13, 2024
Closed
@MarkCallow MarkCallow mentioned this issue Mar 1, 2024
Merged
MarkCallow added a commit that referenced this issue Mar 20, 2024
@MarkCallow @fluppeteer
Flesh out support for VK_FORMAT_R16G16_S10_5_NV. (#864)
42dfae5 
This includes a new round-trip test of vk2dfd and dfd2vk for all Vulkan
formats except multi-plane and modifications to both functions, or
rather their generators, to fix support for some formats, including
VK_FORMAT_R16G16_S10_5_NV and the YUV 4:2:2 single plane formats. Those
listed required changes to`interpretDFD`.

Fixes #859.

Co-authored-by: Andrew Garrard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flesh out support for VK_FORMAT_R16G16_S10_5_NV. KhronosGroup/KTX-Software
1 participant
@MarkCallow