Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker image documenation and default Docker registry. #2412

Open
2 tasks done
DaanSelen opened this issue Jun 9, 2024 · 9 comments
Open
2 tasks done

Add Docker image documenation and default Docker registry. #2412

DaanSelen opened this issue Jun 9, 2024 · 9 comments
Labels
t/request Someone requested a new feature

Comments

@DaanSelen
Copy link

What new feature would you like to see?

Docker container image documentation and a default registry to pull it from, such as Docker Hub?

Which of these categories fit your request?

Other

Just checking...

  • I have confirmed that my feature has not already been requested.
  • I have confirmed that my feature has not already been implemented in the review branch.
@DaanSelen DaanSelen added the t/request Someone requested a new feature label Jun 9, 2024
@ghzeni
Copy link

ghzeni commented Jul 28, 2024

I'm gonna take a look into that. Went through something similar for this bot. I'll keep you updated.

@BabyBoySnow
Copy link
Collaborator

https://hub.docker.com/r/justsomebots/musicbot
It hasn't been updated in 2 years, and I'm not familiar with docker or anything, I'll talk with the other maintainers and see about getting it updated

@pythoninthegrass
Copy link

Hi @DaanSelen et al! I'm participating in this years hacktoberfest and would be happy to take this issue. It'd mean a lot to me if you can mark my PR as hacktoberfest-accepted per the contest rules 🙏

I'll start working on it tonight and should be able to have it done by EOW.

@BabyBoySnow
Copy link
Collaborator

Hi @DaanSelen et al! I'm participating in this years hacktoberfest and would be happy to take this issue. It'd mean a lot to me if you can mark my PR as hacktoberfest-accepted per the contest rules 🙏

I'll start working on it tonight and should be able to have it done by EOW.

I look forward to seeing the PR and what you come up with! I'd be more than happy to mark it as hacktoberfest acccepted if it meets the guidelines :)

@pythoninthegrass
Copy link

Happy to help! Is docker.io a requirement or will ghcr.io suffice? Can do either/or but I like the built-in integration with github actions for the latter.

@BabyBoySnow
Copy link
Collaborator

Happy to help! Is docker.io a requirement or will ghcr.io suffice? Can do either/or but I like the built-in integration with github actions for the latter.

tbh I'm not entirely sure what the code owners would want. It seems @jayktaylor put us on docker hub awhile back, and it hasn't been updated since.

@pythoninthegrass
Copy link

Gotcha. I'll set it up to be flexible and owners can decide which one they want to use later.

@BabyBoySnow
Copy link
Collaborator

I've marked #893 as a good first issue if you'd prefer working more directly with the code. There's not to many open currently lol.

@pythoninthegrass
Copy link

Subscribed! Don't have a lot of bandwidth, so meaningful but straightforward issues like this one are really nice haha

This was referenced Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/request Someone requested a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants