Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use min_enabled_level() instead of .min_level ? #47

Closed
ederag opened this issue Mar 30, 2021 · 2 comments · Fixed by #48
Closed

Use min_enabled_level() instead of .min_level ? #47

ederag opened this issue Mar 30, 2021 · 2 comments · Fixed by #48

Comments

@ederag
Copy link
Contributor

ederag commented Mar 30, 2021

The min_level property is not part of a logger standard interface (found only as a keyword argument).
Using .min_level caused an issue with Pluto custom logger ( fonsp/Pluto.jl#1038).
Perhaps one should use Logging.min_enabled_level() instead ?

@c42f
Copy link

c42f commented Mar 31, 2021

Looking at the code in util.jl, the way it's manipulating global_logger looks kind of dodgy. I haven't used Traceur, but a better alternative may be a single call to with_logger() which wraps the @trace entry point.

(In case you're wondering, I arrived here via fonsp/Pluto.jl#1038)

@ederag
Copy link
Contributor Author

ederag commented Mar 31, 2021

@c42f Thanks for the suggestion, is #49 what you had in mind ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants