Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: DontMaterialize v0.1.0 #118741

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 5f58fed1-7d9e-412e-9290-962e4cbf8d80
Repo: https://github.com/MasonProtter/DontMaterialize.jl.git
Tree: 716ec2c6344b05c6455aecb3944eebaedf39cb9b

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@MasonProtter
Copy link
Contributor

MasonProtter commented Nov 5, 2024

Pause.

It's been pointed out to me that https://github.com/CliMA/LazyBroadcast.jl and https://github.com/CliMA/MultiBroadcastFusion.jl already exist so maybe this isn't needed.

On the other hand, they provide pretty different (IMO significantly clunkier) syntax, and also have some performance differeces (CliMA/LazyBroadcast.jl#14), though that's changeable.

I'm happy to either cancel the registration of this or resume it based on any thoughts or feelings people might have.


Edit: after some discussion with @charleskawczynski, I think I do want to go forward with registering this, as these packages do have some real differences, in particular they operate in different ways, and have different stances on what things like @lazy (x .= y) should mean.

[noblock]

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Nov 5, 2024
@JuliaTagBot JuliaTagBot removed the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Nov 5, 2024
@JuliaTagBot JuliaTagBot merged commit 2932204 into master Nov 8, 2024
20 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-dontmaterialize-5f58fed1-v0.1.0-64b0ae4573 branch November 8, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants