Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename set_errorhandler! to set_errhandler! #500

Open
eschnett opened this issue Aug 25, 2021 · 3 comments · May be fixed by #504 or #615
Open

Rename set_errorhandler! to set_errhandler! #500

eschnett opened this issue Aug 25, 2021 · 3 comments · May be fixed by #504 or #615
Milestone
1.0

Comments

@eschnett
Copy link
Contributor

The MPI standard has a function MPI_Comm_set_errhandler that we (since Julia has overloading) would usually call MPI.set_errhandler!. However, we deviate from "the usual" rules for translating MPI function names, and call it MPI.set_errorhandler! instead.

I think we should use the same name as in the MPI standard.
@simonbyrne simonbyrne added this to the 1.0 milestone Aug 27, 2021
simonbyrne added a commit that referenced this issue Aug 28, 2021
@simonbyrne
rename get/set_errorhandler to errhandler
8542c97 
fixes #500
@simonbyrne simonbyrne linked a pull request Aug 28, 2021 that will close this issue
Open
simonbyrne added a commit that referenced this issue Aug 28, 2021
@simonbyrne
rename get/set_errorhandler to errhandler
d90a52b 
fixes #500
simonbyrne added a commit that referenced this issue Aug 28, 2021
@simonbyrne
rename get/set_errorhandler to errhandler
677a1c1 
fixes #500
simonbyrne added a commit that referenced this issue May 31, 2022
@simonbyrne
rename get/set_errorhandler to errhandler
57ea189 
fixes #500
@simonbyrne
Copy link
Member

I've thought a bit more about this: I personally prefer the longer name.

@sloede
Copy link
Member

sloede commented May 31, 2022

I am all for consistency and descriptiveness in naming things. Since consistency is broken anyways (it would have to be comm_set_errhandler! if I'm not mistaken about the naming scheme), I'd also prefer the descriptive name.

@eschnett
Copy link
Contributor Author

In C, all MPI constants, types, and function names that mention "error handler" use the term errhandler. That makes it easy to remember the names. Currently, MPI.jl chooses errhandler for most, errorhandler for some, and error_handler for another...

@simonbyrne simonbyrne linked a pull request Jun 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
3 participants
@eschnett @simonbyrne @sloede