Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in incomplete_tag #512

Open
Keno opened this issue Oct 12, 2024 · 1 comment
Open

Regression in incomplete_tag #512

Keno opened this issue Oct 12, 2024 · 1 comment

Comments

@Keno
Copy link
Member

Keno commented Oct 12, 2024

On JuliaSyntax master:

julia> s = "CompletionFoo.test(1, 1, "
"CompletionFoo.test(1, 1, "

julia> Base.incomplete_tag(Meta.parse(s, raise=false, depwarn=false))
:none

vs Base:

julia> Base.incomplete_tag(Meta.parse(s, raise=false, depwarn=false))
:other

I looked into adjusting the tag selector a bit, but couldn't come up with a good version that also distinguished [x (with space), [x) and ( and ( , so there may need to be some adjustment to the source-location representation itself. @c42f can you take a look?

@Keno
Copy link
Member Author

Keno commented Oct 12, 2024

ref JuliaLang/julia#56110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant