-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for linear algebra #682
Conversation
The matrix multiplication has become a lot more conservative. Was this intended? julia> A = [interval(2, 4) interval(-2, 1); interval(-1, 2) interval(2, 4)];
julia> A*A # v0.22.16
2×2 Matrix{Interval{Float64}}:
[0.0, 18.0]_com [-16.0, 8.0]_com
[-8.0, 16.0]_com [0.0, 18.0]_com
julia> A*A # v0.22.17
2×2 Matrix{Interval{Float64}}:
[-2.0, 19.5001]_com [-16.0, 10.0]_com
[-10.0, 16.0]_com [-2.0, 19.5001]_com I think this change may have affected the usefulness of the package quite a bit. |
Yes this is intended, the performance is really bad otherwise. |
I think that would be good. (I also think that the latest release should have been marked as a bigger change instead of just a patch release, as the behavior of the package actually changed. It broke the tests in some package. It is also unclear from the PR name that the behavior changed, so I suggest to rename it.) |
Mhm so maybe for the 0.22 releases the default should be |
I agree, the default should be |
@schillic thanks again for bringing this to our attention. The version 0.22.18 should be released soon, which introduces multiplication mode set to |
Thank you, much appreciated! |
Some linear algebra functions are accessible from Base, e.g.
*
andinv
.This PR implements methods for these functions as part of the LinearAlgebra extension to avoid getting error messages and the need to load the more specialised package IntervalLinearAlgebra.
Specifically,
It also defines some methods for the operator norm (
opnorm
) since the default algorithm used the syntaxsum::Tsum = 0
which leads to an unnecessary "NG" flag.I took the tests for matrix multiplication from IntervalLinearAlgebra.
cc @lucaferranti @orkolorko