Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting @atomic macro from julia-1.12 #38

Open
kalmarek opened this issue Jul 8, 2024 · 1 comment
Open

backporting @atomic macro from julia-1.12 #38

kalmarek opened this issue Jul 8, 2024 · 1 comment

Comments

@kalmarek
Copy link

kalmarek commented Jul 8, 2024

pull: JuliaLang/julia#54707
It requires GenericMemory which landed only in julia-1.11, so the backport will be only limited in scope.

@vchuravy how do you envision such a backport?

@vchuravy
Copy link
Member

vchuravy commented Jul 8, 2024

So one idea would be to "simply" @static if and have Atomix just re-export @atomic from Julia Base.

This will likely cause issue with Atomix usage in KernelAbstractions and the GPU backends. One would also need to make sure that the semantics of @atomic match between Base and Atomix.

Alternativly replace the implementation for the CPU in Atomix on 1.12 with direct calls to the Memory related pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants