We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We also need seniority (or something more general, #51) quantum numbers also for jj-coupled CSFs. So, unless I am missing something, I propose:
jj
Making IntermediateTerm parametric (term could be either Term or HalfInteger)
IntermediateTerm
term
Term
HalfInteger
Removing the IT type parameter from CSF, i.e. we'd have
IT
CSF
struct CSF{O<:AbstractOrbital, T<:Union{Term,HalfInteger}} config::Configuration{<:O} subshell_terms::Vector{IntermediateTerm{T}} terms::Vector{T} end
I could look at tackling this, and also maybe fix #50 while I'm at it.
The text was updated successfully, but these errors were encountered:
Introduced separate Seniority type, closes #51 and #59
3d21790
Seniority number in jj-coupling (#64)
820a639
* Introduce seniority for jj-coupled terms/CSFs, &c * Package updates * Fix dependencies in test/excited_configurations.jl * Fix GRASP tests * Introduced separate Seniority type, closes #51 and #59 * Addressed comments * Dropped Julia < 1.2 due to BlockBandedMatrices * Addressed comments * Addressed StackOverflowError Co-authored-by: Morten Piibeleht <[email protected]>
Successfully merging a pull request may close this issue.
We also need seniority (or something more general, #51) quantum numbers also for
jj
-coupled CSFs. So, unless I am missing something, I propose:Making
IntermediateTerm
parametric (term
could be eitherTerm
orHalfInteger
)Removing the
IT
type parameter fromCSF
, i.e. we'd haveI could look at tackling this, and also maybe fix #50 while I'm at it.
The text was updated successfully, but these errors were encountered: