Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize IntermediateTerm slightly #59

Closed
mortenpi opened this issue Oct 23, 2019 · 0 comments · Fixed by #64
Closed

Reorganize IntermediateTerm slightly #59

mortenpi opened this issue Oct 23, 2019 · 0 comments · Fixed by #64

Comments

@mortenpi
Copy link
Member

We also need seniority (or something more general, #51) quantum numbers also for jj-coupled CSFs. So, unless I am missing something, I propose:

  • Making IntermediateTerm parametric (term could be either Term or HalfInteger)

  • Removing the IT type parameter from CSF, i.e. we'd have

    struct CSF{O<:AbstractOrbital, T<:Union{Term,HalfInteger}}
        config::Configuration{<:O}
        subshell_terms::Vector{IntermediateTerm{T}}
        terms::Vector{T}
    end
    

I could look at tackling this, and also maybe fix #50 while I'm at it.

@mortenpi mortenpi linked a pull request Jun 13, 2020 that will close this issue
@jagot jagot closed this as completed in #64 Jun 13, 2020
jagot added a commit that referenced this issue Jun 13, 2020
* Introduce seniority for jj-coupled terms/CSFs, &c

* Package updates

* Fix dependencies in test/excited_configurations.jl

* Fix GRASP tests

* Introduced separate Seniority type, closes #51 and #59

* Addressed comments

* Dropped Julia < 1.2 due to BlockBandedMatrices

* Addressed comments

* Addressed StackOverflowError

Co-authored-by: Morten Piibeleht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant